-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP migration, Env Var name #5997
Merged
dashpole
merged 4 commits into
open-telemetry:main
from
MadVikingGod:mvg/semconv/change-env
Aug 16, 2024
Merged
HTTP migration, Env Var name #5997
dashpole
merged 4 commits into
open-telemetry:main
from
MadVikingGod:mvg/semconv/change-env
Aug 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
approved these changes
Aug 8, 2024
cc @VinozzZ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5997 +/- ##
=====================================
Coverage 65.5% 65.5%
=====================================
Files 203 203
Lines 12918 12918
=====================================
Hits 8466 8466
Misses 4198 4198
Partials 254 254
|
VinozzZ
approved these changes
Aug 8, 2024
dashpole
approved these changes
Aug 8, 2024
pellared
approved these changes
Aug 9, 2024
XSAM
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames the environment variable used for compatibility mode to
OTEL_SEMCONV_STABILITY_OPT_IN
as per the recommendation in the spec.Follow up from this comment.