[chore]: enable usestdlibvars linter

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

.golangci.yml

@@ -2,7 +2,7 @@
 run:
   issues-exit-code: 1 #Default
   tests: true #Default
-  timeout: 2m
+  timeout: 5m
 
 linters:
   # Disable everything by default so upgrades to not include new "default
@@ -32,6 +32,7 @@ linters:
     - unconvert
     - unparam
     - unused
+    - usestdlibvars
 
 issues:
   # Maximum issues count per one linter.
@@ -68,6 +69,7 @@ issues:
       linters:
         - gosec
         - perfsprint
+        - usestdlibvars
   include:
     # revive exported should have comment or be unexported.
     - EXC0012

detectors/azure/azurevm/vm.go

@@ -89,7 +89,7 @@ func (detector *ResourceDetector) getJSONMetadata(ctx context.Context) ([]byte,
 
 	client := http.Client{Transport: pTransport}
 
-	req, err := http.NewRequestWithContext(ctx, "GET", detector.endpoint, nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, detector.endpoint, nil)
 	if err != nil {
 		return nil, false, err
 	}

instrumentation/net/http/httptrace/otelhttptrace/example/client/client.go

@@ -79,7 +79,7 @@ func main() {
 		ctx, span := tr.Start(ctx, "say hello", trace.WithAttributes(semconv.PeerService("ExampleService")))
 		defer span.End()
 
-		req, _ := http.NewRequestWithContext(ctx, "GET", *url, nil)
+		req, _ := http.NewRequestWithContext(ctx, http.MethodGet, *url, nil)
 
 		fmt.Printf("Sending request...\n")
 		res, err := client.Do(req)

instrumentation/net/http/otelhttp/client.go

@@ -18,7 +18,7 @@ var DefaultClient = &http.Client{Transport: NewTransport(http.DefaultTransport)}
 
 // Get is a convenient replacement for http.Get that adds a span around the request.
 func Get(ctx context.Context, targetURL string) (resp *http.Response, err error) {
-	req, err := http.NewRequestWithContext(ctx, "GET", targetURL, nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, targetURL, nil)
 	if err != nil {
 		return nil, err
 	}
@@ -27,7 +27,7 @@ func Get(ctx context.Context, targetURL string) (resp *http.Response, err error)
 
 // Head is a convenient replacement for http.Head that adds a span around the request.
 func Head(ctx context.Context, targetURL string) (resp *http.Response, err error) {
-	req, err := http.NewRequestWithContext(ctx, "HEAD", targetURL, nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodHead, targetURL, nil)
 	if err != nil {
 		return nil, err
 	}
@@ -36,7 +36,7 @@ func Head(ctx context.Context, targetURL string) (resp *http.Response, err error
 
 // Post is a convenient replacement for http.Post that adds a span around the request.
 func Post(ctx context.Context, targetURL, contentType string, body io.Reader) (resp *http.Response, err error) {
-	req, err := http.NewRequestWithContext(ctx, "POST", targetURL, body)
+	req, err := http.NewRequestWithContext(ctx, http.MethodPost, targetURL, body)
 	if err != nil {
 		return nil, err
 	}

instrumentation/net/http/otelhttp/example/client/client.go

@@ -66,7 +66,7 @@ func main() {
 	err = func(ctx context.Context) error {
 		ctx, span := tr.Start(ctx, "say hello", trace.WithAttributes(semconv.PeerService("ExampleService")))
 		defer span.End()
-		req, _ := http.NewRequestWithContext(ctx, "GET", *url, nil)
+		req, _ := http.NewRequestWithContext(ctx, http.MethodGet, *url, nil)
 
 		fmt.Printf("Sending request...\n")
 		res, err := client.Do(req)