Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vertex offset #31

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Fix vertex offset #31

merged 2 commits into from
Sep 14, 2024

Conversation

khdlr
Copy link
Member

@khdlr khdlr commented Sep 14, 2024

Fixes #30

@FlorianK13
Copy link
Member

@khdlr Have you tested then new 0.01 tolerance in the webgl code with actual data used on the website?

@khdlr
Copy link
Member Author

khdlr commented Sep 14, 2024

@khdlr Have you tested then new 0.01 tolerance in the webgl code with actual data used on the website?

Yes, I played around a bit with different values between 0.0 and 0.05, it seems that 0.05 is too high. Things seem to work even with 0.0, but I'm scared of floating point errors here...

@FlorianK13 FlorianK13 self-requested a review September 14, 2024 11:48
@khdlr khdlr merged commit 778f597 into main Sep 14, 2024
2 checks passed
@khdlr khdlr deleted the fix/vertex-offset branch September 14, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore polygon vertex direction (CW/CCW) for computation
2 participants