Skip to content

Commit

Permalink
hw/phb3: Update capi initialization sequence
Browse files Browse the repository at this point in the history
The capi initialization sequence was revised in a circumvention
document when a 'link down' error was converted from fatal to Endpoint
Recoverable. Other, non-capi, register setup was corrected even before
the initial open-source release of skiboot, but a few capi-related
registers were not updated then, so this patch fixes it.

The point is that a link-down error detected by the UTL logic will
lead to an AIB fence, so that the CAPP unit can detect the error.

Signed-off-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
(cherry picked from commit e36f4f2)
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
  • Loading branch information
Frederic Barrat authored and stewartsmith committed Aug 24, 2016
1 parent 3560f40 commit ec1cf51
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion hw/phb3.c
Original file line number Diff line number Diff line change
Expand Up @@ -3287,10 +3287,11 @@ static void phb3_init_capp_regs(struct phb3 *p)
/* override some inits with CAPI defaults */
static void phb3_init_capp_errors(struct phb3 *p)
{
out_be64(p->regs + PHB_ERR_AIB_FENCE_ENABLE, 0xffffffdd0c80ffc0);
out_be64(p->regs + PHB_ERR_AIB_FENCE_ENABLE, 0xffffffdd8c80ffc0);
out_be64(p->regs + PHB_OUT_ERR_AIB_FENCE_ENABLE, 0x9cf3fe08f8dc700f);
out_be64(p->regs + PHB_INA_ERR_AIB_FENCE_ENABLE, 0xffff57fbff01ffde);
out_be64(p->regs + PHB_INB_ERR_AIB_FENCE_ENABLE, 0xfcffe0fbff7ff0ec);
out_be64(p->regs + PHB_LEM_ERROR_MASK, 0x40018e2400022482);
}

static int64_t phb3_set_capi_mode(struct phb *phb, uint64_t mode,
Expand Down

0 comments on commit ec1cf51

Please sign in to comment.