feat: use dto in getfeatures

open-amt-cloud-toolkit · Jul 9, 2024 · 2d3bc4f · 2d3bc4f
1 parent 8f6ecc2
commit 2d3bc4f
Show file tree

Hide file tree

Showing 12 changed files with 79 additions and 602 deletions.
diff --git a/internal/controller/http/v1/devicemanagement.go b/internal/controller/http/v1/devicemanagement.go
@@ -78,7 +78,16 @@ func (r *deviceManagementRoutes) getFeatures(c *gin.Context) {
 		return
 	}
 
-	c.JSON(http.StatusOK, features)
+	v1Features := map[string]interface{}{
+		"redirection": features.Redirection,
+		"KVM":         features.EnableKVM,
+		"SOL":         features.EnableSOL,
+		"IDER":        features.EnableIDER,
+		"optInState":  features.OptInState,
+		"userConsent": features.UserConsent,
+	}
+
+	c.JSON(http.StatusOK, v1Features)
 }
 
 func (r *deviceManagementRoutes) setFeatures(c *gin.Context) {

diff --git a/internal/controller/http/v1/devicemanagement_mocks_test.go b/internal/controller/http/v1/devicemanagement_mocks_test.go
diff --git a/internal/controller/http/v1/devicemanagement_test.go b/internal/controller/http/v1/devicemanagement_test.go
@@ -40,7 +40,7 @@ func deviceManagementTest(t *testing.T) (*MockDeviceManagementFeature, *gin.Engi
 
 var aGoodTime = time.Unix(int64(1073007983), 0)
 
-func TestGetNetworkSettings(t *testing.T) {
+func TestDeviceManagement(t *testing.T) {
 	t.Parallel()
 
 	tests := []struct {
@@ -69,10 +69,10 @@ func TestGetNetworkSettings(t *testing.T) {
 			method: http.MethodGet,
 			mock: func(m *MockDeviceManagementFeature) {
 				m.EXPECT().GetFeatures(context.Background(), "valid-guid").
-					Return(map[string]interface{}{"features": []string{"feature1", "feature2"}}, nil)
+					Return(dto.Features{}, nil)
 			},
 			expectedCode: http.StatusOK,
-			response:     map[string]interface{}{"features": []string{"feature1", "feature2"}},
+			response:     map[string]interface{}{"IDER": false, "KVM": false, "SOL": false, "redirection": false, "optInState": 0, "userConsent": ""},
 		},
 		{
 			name:        "setFeatures - successful setting",