Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose.yaml #936

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update compose.yaml #936

wants to merge 2 commits into from

Conversation

psurabh
Copy link

@psurabh psurabh commented Oct 11, 2024

Updated runtime: runc for a few containers as compilation was failing without it.

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Updated runtime: runc for a few containers as compilation was failing without it.
@@ -34,6 +34,7 @@ services:
- llava-tgi-service
ports:
- "9399:9399"
runtime: runc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don’t need to specify runtime runc manually, as Docker uses runc by default. Why do we need to set it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants