Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added role checks in data source #1092

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jaswanth8888
Copy link
Collaborator

Description

  • Added role checks in data source
  • Users with admin role can upload, delete documents
  • user with user role can only view the existing file

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: Ubuntu <ubuntu@ip-172-31-30-242.us-west-2.compute.internal>
@chensuyue
Copy link
Collaborator

Please check the CI issue, can you pass the test locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants