Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): expose session close #852

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ private void downloadURLs() {
currentTest.setMax_runtime(app.getPreferenceManager().getMaxRuntime());
}
publishProgress(URL);

// we close the session to ensure that we have no running circumvention tunnels
session.close();
} catch (Exception e) {
e.printStackTrace();
ThirdPartyServices.logException(e);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,7 @@ public interface OONISession {
OONIRunDescriptor getLatestOONIRunLink(OONIContext ctx, String probeServicesURL, long id) throws Exception;

OONIRunRevisions getOONIRunLinkRevisions(@Nullable OONIContext ooniContext, @NotNull String probeServicesURL, long runId) throws Exception ;

/** close closes the session along with any running circumvention tunnels */
void close() throws Exception;
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,8 @@ public OONIRunRevisions getOONIRunLinkRevisions(OONIContext ooniContext, @NotNul

return revisions;
}

public void close() throws Exception {
session.close();
}
}
Loading