Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OONI Run v2 #671

Merged
merged 100 commits into from
Oct 21, 2024
Merged

OONI Run v2 #671

merged 100 commits into from
Oct 21, 2024

Conversation

aanorbel and others added 30 commits November 24, 2023 15:08
Fixes  ooni/probe#2596

## Proposed Changes

  - Update designs for Run v1 components to match new designs
  - Add `SrtingListRecyclerViewAdapter` to display List items
  - Convert `OoniRunActivity` to Kotlin
  
| Light | Dark|
|--|--|
|.|.|

|![web_connectivity_light](https://github.com/ooni/probe-android/assets/17911892/6f4b5896-c85a-4cd9-8fb2-0f6eb693f38e)|![web_connectivity_dark](https://github.com/ooni/probe-android/assets/17911892/6a30f612-1b42-4e43-b8e5-0f4a16edf86b)|

|![web_connectivity_light_long_list](https://github.com/ooni/probe-android/assets/17911892/9d871137-fd3b-4b23-9c3a-700d30d43f6b)|
![web_connectivity_dark_long_list](https://github.com/ooni/probe-android/assets/17911892/82c0d8fa-c0b6-4ed1-83ef-607c4bf952c4)|

|![web_connectivity_light_short_list](https://github.com/ooni/probe-android/assets/17911892/42e96ad5-318b-4220-beae-d5d8932da985)|![web_connectivity_dark_short_list](https://github.com/ooni/probe-android/assets/17911892/7aafa54c-5498-40d2-8cbb-f00173e001ee)|

|![http_header_field_manipulation_light](https://github.com/ooni/probe-android/assets/17911892/c79e07be-9044-4cf9-9272-b4be0a6f6d4f)|![http_header_field_manipulation_dark](https://github.com/ooni/probe-android/assets/17911892/d4cb96ed-c6a5-4e55-9a9b-7f47059fde3f)|

|![invalid_light](https://github.com/ooni/probe-android/assets/17911892/05516448-7094-484d-9ccb-f118f489e546)|![invalid_dark](https://github.com/ooni/probe-android/assets/17911892/bc5351fa-770f-43d8-aa65-5265ba4c1cad)|

|![outdated_light](https://github.com/ooni/probe-android/assets/17911892/e475971e-23c0-4f37-9ee1-598ce91bb611)|![outdated_dark](https://github.com/ooni/probe-android/assets/17911892/a94e5849-3eeb-4ad1-a393-4591d5d0f824)|

|![whatsapp_light](https://github.com/ooni/probe-android/assets/17911892/3f9b5760-a259-4838-a28c-1d8db1e8ceed)|![whatsapp_dark](https://github.com/ooni/probe-android/assets/17911892/2313ca90-b5ab-4bb1-ac13-7cc763bc06eb)?
Fixes ooni/probe#2592

## Proposed Changes

  - Updated `CustomWebsiteActivity` to use new theme.
  - Change List item builder to use  `RecyclerView`.


Tasks

- [x] Implement designs on light theme.
- [x] Convert list item builder to  use  `RecyclerView`.
- [x] Fix dark theme
- [x] Implement modal properly

| Light | Dark|
|-|-|

|![Screenshot_20231104_110235](https://github.com/ooni/probe-android/assets/17911892/b4c8dca7-2c6a-4d55-9df4-f194a67b98a6))|
![Screenshot_20231104_110254](https://github.com/ooni/probe-android/assets/17911892/60ade191-40bb-4b0b-a5fa-aa93540bd112)
|

|![Screenshot_20231104_110336](https://github.com/ooni/probe-android/assets/17911892/2df8c97a-23ff-4771-970b-59044de00386)|
![Screenshot_20231104_110407](https://github.com/ooni/probe-android/assets/17911892/291af536-72e3-4774-a5ca-8301334543a0)
|
|
![Screenshot_20231104_110429](https://github.com/ooni/probe-android/assets/17911892/a7423372-5acd-45b8-aa0a-ae2ef4e4b62c)
|
![Screenshot_20231104_110441](https://github.com/ooni/probe-android/assets/17911892/15047e19-9c3e-4cbe-a1c1-ceaa8783da8a)
|

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
Fixes  ooni/probe#2593

## Proposed Changes

  - Merge `Automated Testing` settings into whats left of `Test Options`

|.|.|
|-|-|
|
![Screenshot_20231104_194231](https://github.com/ooni/probe-android/assets/17911892/9e926414-5fec-4181-a586-5e6dd4bc078e)
|
![Screenshot_20231104_194243](https://github.com/ooni/probe-android/assets/17911892/fbdde7f8-d003-48bc-a33d-e72212a82cf2)
|
## Proposed Changes

  - Add `OONIDescriptor` and methods to transform to `DynamicSuite` 
  - Update various components to use descriptors
  - Update tests

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
## Proposed Changes

  - Update `activity_overview.xml` to include list to display tests.
- Add `OverviewTestsExpandableListViewAdapter.kt` and
`OverviewViewModel.kt` to display the list and control actions.
  - Update `OverviewActivity` with various callbacks.

|.|.|.|
|-|-|-|
|
![Screenshot_20231127_191935](https://github.com/ooni/probe-android/assets/17911892/a5b09876-7116-44ae-90c3-29acc8ec8e86)|
![Screenshot_20231127_191947](https://github.com/ooni/probe-android/assets/17911892/4295f34d-03d0-4941-a279-ed86fbc26d6d)|
![Screenshot_20231127_191957](https://github.com/ooni/probe-android/assets/17911892/1802f6cf-47e6-4d64-ba33-d6251b055ff7)|

**NOTE** : Switches in designs replaced with checkbox since the switch
does not have an intermediate state.
The intermediate state is important when some of the component tests are
disabled but not all are disabled.

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
…com:ooni/probe-android into dev/design-update
Fixes OONI cards not enabled by default.

## Proposed Changes

  - Set default value for ooni tests to enabled.
Fixes  ooni/probe#2659 (comment)

## Proposed Changes

- Update `ReadMorePlugin` to take a `maxLength` parameter with default
value `150`.
- Update `OverviewActivity` to allow modification of all automated
update items.
- Update `RunTestsActivity` to save preferences only when the tests are
run.
Fixes ooni/probe#2595

## Proposed Changes

- Add `intent-filter` to `MainActivity` so v2 events are handled by it.
- Load `descriptor` from the backend and send to `AddDescriptorActivity`
to be displayed.
- Ensure `AddDescriptorActivity` doesn't lose state on configuration
change.
## Proposed Changes

- Update `MeasurementDetailActivity` to check test names when displaying
performance results.
- Update `ResultDetailActivity` to use colour of results in themes setup
and use `Experimental` test names to determine where to navigate when
the measurement is clicked.
…en fetching preferences in `RunTestsActivity`
fix: Updated `ProgressFragment` and its position on dashboard.
…tes (#655)

Fixes ooni/probe#2594

## Proposed Changes

- Add a worker to automatically update `descriptors` with `autoUpdate`
enabled every 24 hrs.
- Add a worker to fetch updates for `descriptors` with `autoUpdate`
disabled and return to caller.
- Show progress update for descriptors being fetched and prompt to
review updates for descriptors with `autoUpdate` disabled in
`MainActivity`

|.|.|.|
|-|-|-|
|
![Screenshot_20240123_151744](https://github.com/ooni/probe-android/assets/17911892/69ab0101-1474-4eeb-9921-16151bfd5e1e)
|
![Screenshot_20240123_151752](https://github.com/ooni/probe-android/assets/17911892/4bb9197b-8381-447a-8544-87032f399d9a)
|
![Screenshot_20240123_151808](https://github.com/ooni/probe-android/assets/17911892/0ade0d66-f4df-43e2-ab6a-cdb8d1739e3a)
|
|
![Screenshot_20240124_160104](https://github.com/ooni/probe-android/assets/17911892/6d8d67e0-2b3e-4970-9ef1-87ed07f56563)
|
![Screenshot_20240124_160101](https://github.com/ooni/probe-android/assets/17911892/53b007d6-9c13-4f26-a31f-a3beb47a78f4)
|
![Screenshot_20240124_161236](https://github.com/ooni/probe-android/assets/17911892/e7151462-8395-40f3-8111-91f0b05e2b83)
|

---------

Co-authored-by: Simone Basso <bassosimone@gmail.com>
@aanorbel aanorbel marked this pull request as ready for review July 24, 2024 08:38
aanorbel and others added 27 commits July 24, 2024 10:36
## Proposed Changes

- Update checkbox view on Overview screen, run tests and add descriptor
screens
 

|.|.|.|
|-|-|-|
|
![Screenshot_20240823_125427](https://github.com/user-attachments/assets/e897f606-8814-402f-b532-153669518d47)
|
![Screenshot_20240823_131105](https://github.com/user-attachments/assets/ffa69cc4-bdf8-42a4-8d15-851b78f118fd)
|
![Screenshot_20240823_131729](https://github.com/user-attachments/assets/a96c69f7-17f2-46c9-a361-eecce96c6c98)
|
Fixes  ooni/probe#2795

## Proposed Changes

  - Add OpenVPN to experimental tests/
  - Update tests to reflect change in experimental test.

|.|.|
|-|-|
|
![Screenshot_20240827_154420](https://github.com/user-attachments/assets/6fc2ceae-6966-495e-aa7f-5932fed56a82)
|
![Screenshot_20240827_154432](https://github.com/user-attachments/assets/e43350e0-b25c-450e-afc5-c37bc6b97348)
|
@aanorbel aanorbel merged commit e1207e7 into master Oct 21, 2024
12 of 17 checks passed
@aanorbel aanorbel deleted the dev/ooni-run-v2 branch October 21, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant