Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds functionality to automatically test new networks #513

Closed
wants to merge 8 commits into from

Conversation

aanorbel
Copy link
Member

@aanorbel aanorbel commented May 3, 2022

Fixes ooni/probe#900

Proposed Changes

  • Save last_known_network (ASN)
  • Register broadcast receiver (ConnectivityReceiver) to listen to connectivity change and trigger new test.

@aanorbel aanorbel marked this pull request as ready for review May 18, 2022 14:23
@hellais
Copy link
Member

hellais commented Jul 6, 2023

If I understand this feature correctly, we are adding a new settings which affects the starting of background tests to also be triggered when a network is changed. Is that correct?

If so, do we also consider the options related to background tests when determining if it should run (eg. wifi only, only on power)?
If we do consider these options, what happens if the user is switching from wifi to mobile frequently? Will we be re-triggering the tests very often?

I also wonder if we want to somehow listen to this event while we are running a test too and if we notice a network change during a running test operation, we can interrupt it (this would allow us to detect the changes in network and avoid mislabeling measurements with the wrong network information).

@aanorbel aanorbel closed this Jul 5, 2024
@aanorbel aanorbel deleted the issues/900 branch October 21, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mobile: add functionality to automatically test new networks
2 participants