Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation tests coverage workaround #360

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Sep 6, 2022

  • Enable testCoverage only for instrumentation tests and disable the flag after
  • Add the path for the new instrumentation test coverage ec file. The path for this ec file is still different from the one that is generated with the coverage enabled and therefore not stable

Relates to #358

Experimental: This is a possible workaround that is going to be flaky and will need to be removed once the issue is officially resolved

@ekigamba ekigamba changed the title Add instrumentation tests workaround Add instrumentation tests coverage workaround Sep 6, 2022
@ekigamba ekigamba force-pushed the instrumentation-coverage-workaround branch 2 times, most recently from 4e2400b to 7dead40 Compare September 6, 2022 09:58
- Enable testCoverage only for instrumentation tests and disable the flag after
- Add the path for the new instrumentation test coverage ec file

Relates to #358
@ekigamba ekigamba force-pushed the instrumentation-coverage-workaround branch from 7dead40 to 5eb8bbc Compare September 6, 2022 10:38
@coveralls
Copy link

coveralls commented Sep 6, 2022

Pull Request Test Coverage Report for Build #587

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.4%) to 53.545%

Totals Coverage Status
Change from base Build #585: 9.4%
Covered Lines: 3164
Relevant Lines: 5909

💛 - Coveralls

- Fix flaky build
@ekigamba
Copy link
Contributor Author

ekigamba commented Sep 7, 2022

Coveralls cannot link to the correct source code on the repository
Screenshot from 2022-09-07 15-59-23

This is the issue but this seems to be resolved

@ekigamba
Copy link
Contributor Author

Coveralls seems to have an issue related to Java 11 gradle/gradle#9764 gradle/gradle#8286 that generates the wrong source path

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants