-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly escape interpolation-like strings in resolved configs #1113
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I think this needs tests to show what it's actually doing and to ensure it does not break in the future. |
Oh yes (see point 1 above)
I need to think about it a bit more, but I don't believe this is an issue. Will keep it in mind though. |
Hey I noticed a breaking change with this. See full description of it here: #1112 (comment) |
Fixes #1112
Fixes #1081
This is a draft PR for several reasons:
to_container()
andto_object()
needs to be looked at (see Escaped resolver modifying_root_
doesn't work #1120)Note that this is a breaking change, but it can be argued that the previous behavior was a bug (all tests pass).