adição do load-data ao comando run e atualização do README #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inclui o comando `load-data` na regra `.PHONY: run` no Makefile para garantir que os dados sejam carregados ao executar o target `run`.
…a e correção do comando make rerun para make re-run Removi a descrição desatualizada do comando `make load-data` e corrigi o comando `make rerun` para `make re-run` no README para refletir as mudanças recentes no Makefile.
ogecece
approved these changes
Jul 18, 2024
| @@ -36,7 +36,7 @@ wait-for=(podman run --rm -ti --volume $(PWD):/mnt/code:rw \ | |||
| --pod $(POD_NAME) \ | |||
| --env PYTHONPATH=/mnt/code \ | |||
| --user=$(UID):$(UID) \ | |||
| $(IMAGE_NAMESPACE)/$(IMAGE_NAME):$(IMAGE_TAG) wait-for-it --timeout=30 $1) | |||
| $(IMAGE_NAMESPACE)/$(IMAGE_NAME):$(IMAGE_TAG) wait-for-it --timeout=90 $1) | |||
There was a problem hiding this comment.
Vi aqui que modificou. Provavelmente por conta do Opensearch, certo? Vou deixar essa modificação no PR, pois é um problema que já aconteceu antes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Este pull request faz as seguintes alterações:
Makefile:
Adiciona o comando
load-dataao target .PHONY: run. Isso garante que, ao executarmake run, os dados necessários sejam carregados corretamente, melhorando a inicialização do ambiente.README:
Remove a referência ao comando
make load-data, que agora está integrado ao comandorun.Corrige o comando
make rerunparamake re-runpara refletir a sintaxe correta no Makefile.Alterações detalhadas
Makefile:
README: