-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Migrate backend to Deno #1395
Open
snowteamer
wants to merge
56
commits into
okTurtles:master
Choose a base branch
from
snowteamer:add-deno-version-without-pogo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP - Migrate backend to Deno #1395
snowteamer
wants to merge
56
commits into
okTurtles:master
from
snowteamer:add-deno-version-without-pogo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowteamer
force-pushed
the
add-deno-version-without-pogo
branch
from
August 29, 2022 16:09
3bdba00
to
4a37434
Compare
taoeffect
reviewed
Aug 31, 2022
taoeffect
requested changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive work @snowteamer! This involved a deep understanding of the differences between Node and Deno.
This is just a preliminary review, nothing serious, two change requests:
UseEDIT: oops, seems like you already did this!.push
instead of.length
for streaming APIs, and in general get them to match the original code as much as possible- Go through the logging stuff and try to match the original logging as closely as possible
taoeffect
reviewed
Sep 10, 2022
snowteamer
force-pushed
the
add-deno-version-without-pogo
branch
2 times, most recently
from
October 20, 2022 14:37
7cb4f8c
to
1ea0bb6
Compare
snowteamer
force-pushed
the
add-deno-version-without-pogo
branch
from
October 20, 2022 14:43
1ea0bb6
to
ea78079
Compare
…to add-deno-version-without-pogo
Wonder if these updates to Deno are relevant? https://deno.com/blog/v1.35 |
taoeffect
added
Note:Research
Note:Stale
Closed due to inactivity / relevance / memory
labels
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #586
Summary of changes:
An okTurtles-based fork could be used as well.
backend/
andshared/
have been converted to TypeScript.shared/
were still necessary and have been moved to newtypes.flow.js
files in their respective folders.backend:launch
andbackend:relaunch
have been replaced withdeno:start
.deno:stop
andflow:stop
tasks, used to avoid dangling process issues.exec:ts
task for typechecking backend and shared files.Additional info:
Known issues and limitation:
Remaining tasks:
--watch
flag to implementnpm backend
script equivalent functionality without using Nodemondeno check
deno test
for backend unit tests