MAINT: Update coveragerc #1050
Open
MAINT: Update coveragerc #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, did you check where this decrease of coverage comes from? Seems like some stuff is omitted that shouldn't. |
|
I agree, something definitely went wrong here. I'll look through it |
|
Status? |
|
I'll merge this for now, but it seems our coverage is lower than we thought :/ |
|
Please remove the "merge master into branch" commit. |
kohr-h
reviewed
Nov 14, 2017
| @@ -10,16 +10,19 @@ omit = | |||
| odl/diagnostics/* | |||
| odl/util/* | |||
|
|
|||
| # Omit until coveralls supports cuda. | |||
| odl/space/cu_ntuples.py | |||
|
|
|||
| # Omit until coveralls supports pywt. | |||
| odl/trafos/wavelet.py | |||
There was a problem hiding this comment.
We install pywavelets on Travis now, so this line can be removed.
kohr-h
reviewed
Nov 14, 2017
| @@ -46,6 +49,13 @@ exclude_lines = | |||
| # Decorators | |||
There was a problem hiding this comment.
Comment here: return NotImplemented should go off the list, since it's part of actual functionality.
There was a problem hiding this comment.
Instead, we may think about adding the RuntimeError stuff that's just defensive coding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file has obviously become way outdated