Implement 'available' sub-command, add support for aarch64 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The situations this commit covers is:
Invalid architecture
Invalid OS
As well as providing a simpler message for when the requested JDK
version isn't found. This message still isn't as simple as I'd like, as
it gets wrapped in 2 other errors, but it's a lot better than before.
DenWav
force-pushed
the
available-command
branch
2 times, most recently
from
ac75ac9
to
44c50a7
Compare
This will include the platform OS and architecture in the API call so only actually valid versions will be shown.
DenWav
force-pushed
the
available-command
branch
from
44c50a7
to
8a4cb6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
availablesubcommand queries the API to return a list of major JDK versions which could be downloaded and installed from the chosen host.This includes a commit which moves some stuff around to make the above change easier, but also to provide some nicer error messages for unsupported systems or unavailable versions.
Adding aarch64 support allows this to work correctly on M1 macOS as well.