-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install foot-terminfo package #1399
base: master
Are you sure you want to change the base?
Conversation
Errored hosts (64)Changed hosts (0)Unaffected hosts (0)WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/ocfbot/338c729ec68c0c83944316a878b2617e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this errored because codename is a string not a number. For an example of how to do this, see...
puppet/modules/ocf/manifests/packages.pp
Lines 136 to 142 in e50094f
# TODO: remove this once we no longer support stretch (and move to above | |
# packages block) | |
if $::os[distro][codename] != 'stretch' { | |
package { | |
'kitty-terminfo':; | |
} | |
} |
Errored hosts (66)Changed hosts (0)Unaffected hosts (0)WARNING: Output is too long for a comment, posted to a gist instead: https://gist.github.com/ocfbot/7994df5f42d334c9acdf5d0b6942716c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this still fails because of an extra space on line 137...
[2023-09-18T20:09:49.871Z] Trim Trailing Whitespace........................................................................Failed
[2023-09-18T20:09:49.871Z] - hook id: trailing-whitespace
[2023-09-18T20:09:49.871Z] - exit code: 1
[2023-09-18T20:09:49.871Z] - files were modified by this hook
[2023-09-18T20:09:49.871Z]
[2023-09-18T20:09:49.871Z] Fixing modules/ocf/manifests/packages.pp
[2023-09-18T20:09:49.871Z]
To avoid issues like this in the future you should install the pre-commit hooks: https://github.com/ocf/puppet#linting-and-validating-the-puppet-config
Also, |
Errored hosts (0)Changed hosts (65)Unaffected hosts (1)Changed hostsdiff for acid.ocf.berkeley.edu, anthrax.ocf.berkeley.edu, arsenic.ocf.berkeley.edu, asteroid.ocf.berkeley.edu, autocrat.ocf.berkeley.edu, avalanche.ocf.berkeley.edu, bedbugs.ocf.berkeley.edu, bermudatriangle.ocf.berkeley.edu, bigbang.ocf.berkeley.edu, biohazard.ocf.berkeley.edu, blackout.ocf.berkeley.edu, blight.ocf.berkeley.edu, blizzard.ocf.berkeley.edu, chaos.ocf.berkeley.edu, corruption.ocf.berkeley.edu, coup.ocf.berkeley.edu, cyanide.ocf.berkeley.edu, cyclone.ocf.berkeley.edu, dataloss.ocf.berkeley.edu, deadlock.ocf.berkeley.edu, death.ocf.berkeley.edu, dementors.ocf.berkeley.edu, democracy.ocf.berkeley.edu, destruction.ocf.berkeley.edu, dev-death.ocf.berkeley.edu, drought.ocf.berkeley.edu, fallingrocks.ocf.berkeley.edu, famine.ocf.berkeley.edu, firestorm.ocf.berkeley.edu, firewhirl.ocf.berkeley.edu, flood.ocf.berkeley.edu, fraud.ocf.berkeley.edu, frostbite.ocf.berkeley.edu, gridlock.ocf.berkeley.edu, hailstorm.ocf.berkeley.edu, hal.ocf.berkeley.edu, headcrash.ocf.berkeley.edu, heatwave.ocf.berkeley.edu, hurricane.ocf.berkeley.edu, implosion.ocf.berkeley.edu, invasion.ocf.berkeley.edu, lethe.ocf.berkeley.edu, lightning.ocf.berkeley.edu, madcow.ocf.berkeley.edu, maelstrom.ocf.berkeley.edu, meteorstorm.ocf.berkeley.edu, outbreak.ocf.berkeley.edu, pestilence.ocf.berkeley.edu, plague.ocf.berkeley.edu, quarantine.ocf.berkeley.edu, reaper.ocf.berkeley.edu, riptide.ocf.berkeley.edu, scurvy.ocf.berkeley.edu, segfault.ocf.berkeley.edu, sinkhole.ocf.berkeley.edu, supernova.ocf.berkeley.edu, surge.ocf.berkeley.edu, thunder.ocf.berkeley.edu, tornado.ocf.berkeley.edu, tsunami.ocf.berkeley.edu, venom.ocf.berkeley.edu, volcano.ocf.berkeley.edu, whiteout.ocf.berkeley.edu, wildfire.ocf.berkeley.edu, windshear.ocf.berkeley.edu*******************************************
+ Package[foot-terminfo] =>
parameters =>
"allow_virtual": false
******************************************* Unaffected hosts
|
#1351 relevant (I should really get that merged...) |
@jaysa68 uses this terminal emulator