Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

burnin validation #19

Merged
merged 2 commits into from
Aug 19, 2024
Merged

burnin validation #19

merged 2 commits into from
Aug 19, 2024

Conversation

wleoncio
Copy link
Member

Added validation to burnin < nIter, as suggested on #18 (comment).

stopifnot() doesn't provide great error messages, though, so if we're going to do many more of these, I suggest we start using a package like assertthat or checkmate. The former tends to provide more useful messages, while the latter has a lower overhead.

@wleoncio wleoncio requested a review from zhizuio August 19, 2024 08:32
@zhizuio zhizuio merged commit 120070c into main Aug 19, 2024
4 checks passed
@wleoncio wleoncio deleted the burnin-validation branch August 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants