Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CI): Use macos-13 for static-builds #603

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

erikmd
Copy link
Member

@erikmd erikmd commented Jul 26, 2024

Cc @AltGr

  • Kind: bugfix

Description

as macos-14 only provide arm builds now.

Related: actions/runner-images#9741

Checklist

Note to maintainers

  • Read this wiki page.
  • Make sure the PR has a milestone.
  • Assign yourself before merging.
  • Either do a regular merge:
    • for PRs containing several commits following conventional-commits,
    • or for PRs containing 1 commit shared with a later PR (to preserve the SHA1)
  • Or do a squash-merge:
    • for PRs containing only 1 commit (not shared with a later PR),
    • or for PRs containing several commits that need not be kept in the history;
    • Update the commit message header with a conventional-commit type,
    • Add a footer Close #… if a related issue exists.

as macos-14 only provide arm builds now.

Related: actions/runner-images#9741
@erikmd
Copy link
Member Author

erikmd commented Jul 26, 2024

@AltGr when the CI is green, feel free to squash-merge this PR, then rebase #602 on master,

or if ever you prefer, rebase #602 now on #603, then merge the two PR, without squash-merging #602 (in order not to raise a git conflict)

@AltGr
Copy link
Collaborator

AltGr commented Jul 26, 2024

Thanks a lot!

@AltGr AltGr merged commit d2c8d65 into ocaml-sf:master Jul 26, 2024
12 checks passed
@erikmd erikmd deleted the use-macos-13 branch July 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants