-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Improve the tutorial howto-deploy-learn-ocaml-statically #504
base: master
Are you sure you want to change the base?
Conversation
LGTM as the first cheap step to get good instructions. |
Suggestion 1: At some point, we should inline the contents in the main repository to avoid spreading knowledge in several |
Suggestion 2: The commands are mentioning a specific version of learnocaml. |
(I can turn the suggestions into issues!) |
FYI @AltGr I'm reworking this PR (sorry for the delay) to better document how-to download the static build artifacts from any learn-ocaml commit. If you don't object, I will integrate this picture in the Markdown documentation: (Stay tuned) |
Yeah Github is terrible in that regard... making artifacts easily available should be a no-brainer. Even with the screenshot I am not sure this is a viable solution because it requires you to have an account and be logged into Github (and consequently doesn't work with The workaround I could find, which I used here is to rely on github-pages, which provides a publicly accessible space. Sorry, I should have pointed out this possibility earlier but for some reason thought we already had a solution for this. |
504299a
to
55da297
Compare
Kind: documentation
View rendered version of the PR
Description
Change the repository example mentioned in:
https://ocaml-sf.org/learn-ocaml/howto-deploy-learn-ocaml-statically
to link to the longer documentation available in:
https://github.com/erikmd/learn-ocaml-meetup-demo-repository#readme
Checklist
Note to maintainers
Fix #…
if need be)