-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Indy join class request page #79
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @faucomte97)
-- commits
line 1 at r1:
general comment: need to update the PR name to follow semantic release conventions
src/pages/studentJoinClass/StudentJoinClass.tsx
line 6 at r1 (raw file):
import type { SessionMetadata } from "codeforlife/hooks" import { Typography } from "@mui/material" import { handleResultState } from "codeforlife/utils/api.tsx"
no file extension codeforlife/utils/api
. Please remove file extensions from all imports
src/pages/studentJoinClass/StudentJoinClass.tsx
line 43 at r1 (raw file):
details. </Typography>
delete blank line
src/pages/studentJoinClass/StudentJoinClass.tsx
line 44 at r1 (raw file):
</Typography> <UpdateRequestingToJoinClassForm
RequestToJoinClassForm
src/pages/studentJoinClass/StudentJoinClass.tsx
line 45 at r1 (raw file):
<UpdateRequestingToJoinClassForm indyUser={{
indyUser={user}
src/pages/studentJoinClass/RequestPending.tsx
line 19 at r1 (raw file):
const school = result.data if (!school) return <CircularProgress />
please use the util: handleResultState (this is what it's for)
Code quote:
const result = useRetrieveSchoolQuery(user.requesting_to_join_class!.school)
const school = result.data
if (!school) return <CircularProgress />
src/pages/studentJoinClass/RequestPending.tsx
line 44 at r1 (raw file):
decision. </Typography>
delete blank line
src/pages/studentJoinClass/RequestPending.tsx
line 46 at r1 (raw file):
<Stack direction="row" spacing={2}> <Button
Please use LinkButton component instead.
import {LinkButton} from "codeforlife/components/router"
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 21 at r1 (raw file):
return ( <>
delete. only one top-level component.
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 51 at r1 (raw file):
required />
delete blank line.
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 53 at r1 (raw file):
<Stack direction="row" spacing={2} paddingY={3}> <Button
Use LinkButton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 11 unresolved discussions (waiting on @SKairinos)
Previously, SKairinos (Stefan Kairinos) wrote…
general comment: need to update the PR name to follow semantic release conventions
Done.
src/pages/studentJoinClass/RequestPending.tsx
line 19 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
please use the util: handleResultState (this is what it's for)
Done.
src/pages/studentJoinClass/RequestPending.tsx
line 44 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
delete blank line
Done.
src/pages/studentJoinClass/RequestPending.tsx
line 46 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
Please use LinkButton component instead.
import {LinkButton} from "codeforlife/components/router"
Done, also path was wrong.
src/pages/studentJoinClass/StudentJoinClass.tsx
line 6 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
no file extension
codeforlife/utils/api
. Please remove file extensions from all imports
Done.
src/pages/studentJoinClass/StudentJoinClass.tsx
line 43 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
delete blank line
Done.
src/pages/studentJoinClass/StudentJoinClass.tsx
line 44 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
RequestToJoinClassForm
Done.
src/pages/studentJoinClass/StudentJoinClass.tsx
line 45 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
indyUser={user}
😞
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 21 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
delete. only one top-level component.
Done.
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 51 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
delete blank line.
Done.
src/pages/studentJoinClass/UpdateRequestingToJoinClassForm.tsx
line 53 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
Use LinkButton
Done.
This change is