fix: Allow requester indies to retrieve school

[faucomte97]

This change is 

[SKairinos]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @faucomte97)

---

codeforlife/user/views/school_test.py line 75 at r1 (raw file):

        to join.
        """
        user = IndependentUser.objects.get(username="indy.requester@email.com")

to make the code more resilient and readable, get the first instance of an object that matches your testing conditions.

generally not good practice to refer to test data by a unique identifier and assume the data meets the conditions your test needs.

user = IndependentUser.objects.filter(...an indy user that is requesting to join a class...).first()

---

codeforlife/user/views/school.py line 35 at r1 (raw file):

        user = self.request.auth_user
        if user.student:
            if user.student.class_field:

no need to do this if check. delete this if check and then put the if check: if user.student.pending_class_request: before this return.

[faucomte97]

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @SKairinos)

---

codeforlife/user/views/school.py line 35 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

no need to do this if check. delete this if check and then put the if check: if user.student.pending_class_request: before this return.

Done.

---

codeforlife/user/views/school_test.py line 75 at r1 (raw file):

Previously, SKairinos (Stefan Kairinos) wrote…

to make the code more resilient and readable, get the first instance of an object that matches your testing conditions.

generally not good practice to refer to test data by a unique identifier and assume the data meets the conditions your test needs.

user = IndependentUser.objects.filter(...an indy user that is requesting to join a class...).first()

Done.