Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #2919

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Create pull_request_template.md #2919

wants to merge 2 commits into from

Conversation

matentzn
Copy link
Contributor

@matentzn matentzn commented Jun 12, 2023

Lets create specific checklists for the core editorial cases. Max 5 per section.

Related: #2275

@matentzn matentzn marked this pull request as draft June 12, 2023 13:46
- [ ] If an equivalent class axiom is added, a "dc:conformsTo" annotation needs to be added linking to the corresponding design pattern
- [ ] If a class is changed that has any indirect children, associated with them (more than two levels of classes underneath),
it must be reviewed by member of core Uberon team

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] #gogoeditdiff is run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will adding this comment trigger the gogoeditdiff?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but not sure if the checkbox will avoid that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants