-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uberon should make use of xrefs in other ontologies #2801
Comments
Of note, FlyBase has switched (for a few months already) to maintaining and providing its mappings with Uberon/CL under the forms of a SSSOM mapping set, and the idea with @matentzn was to slowly generalise the use of SSSOM mapping sets up to the point where they could replace cross-references entirely. Especially now that we (finally) have dedicated mapping predicates to represent cross-species mappings ( So what I’d propose here would be that, for each foreign ontology (FO):
Also, independently of the generation of bridge files, we would collect all the mapping sets and convert them into a “mapping” component (containing annotations of the form Optionally, the collected mapping sets could also be converted to a second component where the mapping are converted to cross-references (annotations of the form |
Regarding the question of the “source of truth” for the mappings to each foreign ontology: I think that we should have an agreement with each foreign ontology as to which side is going to provide the mappings (whether they are provided as a SSSOM mapping set or as cross-references), rather than trying to merge Uberon-maintained mappings with foreign-maintained mappings and raise an issue when we find clashes. That is, we reach out to the maintainers of each foreign ontology and ask them if they want to manage their Uberon/CL mappings on their side. If they do, we delete all the cross-references we may currently have in Uberon/CL, and we use instead what they provide (as explained in the previous message). If they don’t, then we keep maintaining the mappings on the Uberon/CL side1, and we don’t even try to fetch any mapping set or cross-references from them. -- Footnotes
|
Of note, we should keep in mind that there is also the case of foreign ontologies that provide so-called “complex mappings” – mappings that for some reason are too complex to be expressed as cross-references or as a SSSOM mapping set (one of the “S” in SSSOM stands for “simple” after all). In such a case, it’s the responsibility of the foreign ontology to directly provide a bridge file ready to use. Currently, this is the case of (at least) MBA/DMBA. |
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken. |
Since #3061 we have all the needed infrastructure in place to use externally provided mappings, whether those mappings are provided directly as a SSSOM set (as is the case for the FBbt-provided mappings) or as cross-references (as is the case for the ZFA-provided mappings). |
This issue has not seen any activity in the past 6 months; it will be closed automatically one year from now if no action is taken. |
Historically uberon was the only SOT for mappings, but we have not kept the mapping pipelines up to date and there are now sometimes mappings curated in external AOs (e.g. XAO #2796).
We should add a step to include these. I suggest a periodic slurp into the edit file where they will be visible to editors rather than just at release time.
Before doing we should make sure there are checks in place to avoid introducing non 1-1 mappings. The SOP is that if on running a slurp the editor finds these, to raise an issue on either this tracker (if uberon mapping is questionable) or external AO tracker.
This could be done as part of a boomer-like workflow but this is probably overkill.
perhaps the script that generates bridge files for CL can be adapted (in contrast to Uberon, CL treats many upstreams as SOT).
Or it might be easiest to do in OAK. Basically just query the upstream for X-to-Uberon and flip that into
The text was updated successfully, but these errors were encountered: