Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are we making this change?
The cynic schema module is overly verbose - the same data could be expressed with less code.
What effects does this change have?
Field
trait, moving its data into theHasField
&HasInputField
traits.HasInputField
to an associated type.This reduces the size of the schema module quite considerably, which should have a reasonable impact on compile times (~a 10% reduction in compile times of my test crate that uses the GitHub schema). It also has the bonus impact of simplifying some of the query building where clauses.
This is probably a breaking change though so should maybe be a major release.
Fixes #712