-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: variable inlining feature #1013
base: main
Are you sure you want to change the base?
Conversation
97b5ed5
to
bc71a86
Compare
Why not implement it directly to |
I tried that and it had some downsides:
|
6a5cdfe
to
51ddab8
Compare
✅ Deploy Preview for cynic-querygen-web canceled.
|
Understand. I'm still really surprised you even took the effort. This would work well with some derive persistence system for query-gen, where you can add additional derives to the generated structs. That would be awesome. I'm sure more people could use this. |
Btw why not use generics instead of dyn? |
Using generics would have meant one of:
Whereas dynamic dispatch avoids most of these downsides, and doesn't introduce many I can think of. |
Makes sense |
Why are we making this change?
Cynic now supports inlining variables as a first class feature.
What effects does this change have?
Adds an example and documentation for this feature
TODO:
QueryBuilder
etc. #1008 is merged avoid using OperationBuilder directly in this