Merge pull request #13 from SharifRafid/master

Android: Changed Response Error Body Parsing Via Retrofit
obboy · Aug 5, 2021 · de7bd2a · de7bd2a
2 parents 117bda7 + ada1492
commit de7bd2a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/android/app/src/main/java/life/nsu/aether/repositories/RefreshRepository.java b/android/app/src/main/java/life/nsu/aether/repositories/RefreshRepository.java
@@ -17,11 +17,14 @@
 import org.json.JSONObject;
 
 import java.io.IOException;
+import java.lang.annotation.Annotation;
 
 import life.nsu.aether.utils.networking.NetworkingService;
 import life.nsu.aether.utils.networking.responses.RefreshResponse;
+import okhttp3.ResponseBody;
 import retrofit2.Call;
 import retrofit2.Callback;
+import retrofit2.Converter;
 import retrofit2.Response;
 
 public class RefreshRepository {
@@ -57,19 +60,18 @@ public void onResponse(@NonNull Call<RefreshResponse> call, @NonNull Response<Re
                 if (response.body() != null) {
                     refreshResponseMutableLiveData.postValue(response.body());
                     Log.d("refreshResponse", response.body().getMessage() +" " + response.body().isSuccess() + " " + response.body().getAccessToken());
-
                 }
-
                 if(response.errorBody() != null){
+                    Converter<ResponseBody, RefreshResponse> converter
+                            = NetworkingService.getInstance().retrofit
+                            .responseBodyConverter(RefreshResponse.class, new Annotation[0]);
+                    RefreshResponse errorResponse = null;
                     try {
-                        JSONObject errorObject = new JSONObject(response.errorBody().string());
-                        refreshResponseMutableLiveData.postValue(new RefreshResponse(false, "Login first!", ""));
-                        Log.d("refreshResponse", " "+errorObject);
-
-                    } catch (JSONException | IOException e) {
+                        errorResponse = converter.convert(response.errorBody());
+                        refreshResponseMutableLiveData.postValue(errorResponse);
+                    } catch (IOException e) {
                         e.printStackTrace();
                     }
-
                 }
 
             }

diff --git a/android/app/src/main/java/life/nsu/aether/utils/networking/NetworkingService.java b/android/app/src/main/java/life/nsu/aether/utils/networking/NetworkingService.java
@@ -16,7 +16,7 @@
 public class NetworkingService {
 
     private static NetworkingService mInstance = null;
-    Retrofit retrofit;
+    public Retrofit retrofit;
 
     public static synchronized NetworkingService getInstance() {
         if (mInstance == null) {