Configurable kcadm config delay

[arso]

This patch makes a configuration delay more flexible to avoid
unnecessary long delays on more powerful machines.

The delay can now be set using OVE property ie.

engine-setup --otopi-environment="OVESETUP_KEYCLOAK_CONFIG/configDelaySeconds=int:5"

Signed-off-by: Artur Socha asocha@redhat.com

[mwperina]

Can't we use some health check? For example https://github.com/thomasdarimont/keycloak-health-checks

[arso]

Can't we use some health check? For example https://github.com/thomasdarimont/keycloak-health-checks

I am rather reluctant to use that 3rd party module. It might be working perfectly but from the support perspective this is additional responsibility and additional work. I would stick to anything provided 'out of the box' with official Keycloak distributions.
However, after a quick research I did not find it.
Some time ago I created an issue to track it #15. For now I don't think this whole thing is urgent enough to investigate it. I would stick with some sensible default or make it configurable (this PR) to test different values.
On my VMs I can easily use 5s delay and never get this to happen, however, on OST machines this delay might be bigger (not sure if it needs to be 30seconds like already hardcoded )

[michalskrivanek]

Can't we use some health check? For example https://github.com/thomasdarimont/keycloak-health-checks
I am rather reluctant to use that 3rd party module. It might be working perfectly but from the support

right, please don't

perspective this is additional responsibility and additional work. I would stick to anything provided 'out of the box' with official Keycloak distributions. However, after a quick research I did not find it. Some time ago I created an issue to track it #15. For now I don't think this whole thing is urgent enough to investigate it. I would stick with some sensible default or make it configurable (this PR) to test different values. On my VMs I can easily use 5s delay and never get this to happen, however, on OST machines this delay might be bigger (not sure if it needs to be 30seconds like already hardcoded )

who starts it and where?

[arso]

Can't we use some health check? For example https://github.com/thomasdarimont/keycloak-health-checks
I am rather reluctant to use that 3rd party module. It might be working perfectly but from the support

right, please don't

perspective this is additional responsibility and additional work. I would stick to anything provided 'out of the box' with official Keycloak distributions. However, after a quick research I did not find it. Some time ago I created an issue to track it #15. For now I don't think this whole thing is urgent enough to investigate it. I would stick with some sensible default or make it configurable (this PR) to test different values. On my VMs I can easily use 5s delay and never get this to happen, however, on OST machines this delay might be bigger (not sure if it needs to be 30seconds like already hardcoded )

who starts it and where?

The process is that keycloak module/app is 'registered' on wildfly/eap just like ovirt engine. During wildfly startup this application bootstraps itself if needed. For example it creates database schema. This keycloak app initial startup process might take a bit and is asynchronous for setup code. That is why a short delay is needed or in perfect world some sort of 'ready' endpoint would be even better. Unfortunately, up to my konwledge keycloak does not have anything like that. My initial idea was to implement re-try ... but simple sleep is much easier. Eventually, I would love to return to more legit approach (when other more pressing issues are resolved)