-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imagine if we could run 1000's of queries nightly in Quepid!!! #976
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corsego/161-gem-ferrum@34cd066 for an example! |
Reminder: check the |
Closing in favour of #1039 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This takes the existing Angular1 app and makes a small stripped version that just runs the query and the splainer stuff, and dumps out a text field in the "Snapshot" JSON format. Then, this is exposed by the api
/api/agent_q/fetch
as the JSON response. Oh, how does the API get the data? Glad you asked friend! The API instantiates Chrome and uses Chrome to invoke the stripped down case! It's like that movie Inception ;-).Motivation and Context
We have lots of logic in JavaScript and to move it out of there appears to be sissyphean... Leading us down the "big rewrite" path. Let's encapsulate the Angular1 and not expose it to more things.
Let's make it possible to run lots of queries... So if you have 5000 queries, let's run them in batches of 50, and we invoke the browser 100 times. Or batches of 10 and invoke it 500 times!
How Has This Been Tested?
Screenshots or GIFs (if appropriate):
Types of changes
Checklist: