Migrate unit tests to satysfi-test #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeptometer
commented
Feb 18, 2021
| @@ -6,6 +6,29 @@ | |||
|
|
|||
| type ordering = Lt | Gt | Eq | |||
|
|
|||
| module Ordering : sig | |||
There was a problem hiding this comment.
Added eq for ordering. I'm a bit afraid that Ord and Ordering are confusing. Any suggestion?
nyuichi
reviewed
Feb 18, 2021
zeptometer
force-pushed
the
zeptometer/GH-142
branch
from
29996cc
to
bd6fbeb
Compare
zeptometer
force-pushed
the
zeptometer/GH-142
branch
from
bd6fbeb
to
ab9d894
Compare
This commit splits Lexer from typeset/code2.satyh for testability.
zeptometer
force-pushed
the
zeptometer/GH-142
branch
from
c2cfc3a
to
f3604d2
Compare
zeptometer
commented
Mar 4, 2024
|
|
||
| let promise-test-cases = open Test in | ||
| describe `promise module` [ | ||
| it `evaluate lazily` (fun () -> ( |
There was a problem hiding this comment.
- The original test uses
Debug.logto check the order of side effects, but this is not feasible with the satisfy-test. Instead, this test case usesrefto make side effects. - The original test has additional cases that I did not find helpful. That's why they are omitted in this test case.
zeptometer
commented
Mar 4, 2024
| test (seq (group (many1 char-a)) (group (many1 char-b))) `aabbb` | ||
| |> Expect.is-true | ||
| )); | ||
| % TODO GH-142: Is this right description? |
There was a problem hiding this comment.
I try to make descriptions from test cases, but I need more confidence with some of them. Need help from @nyuichi
zeptometer
force-pushed
the
zeptometer/GH-142
branch
from
f3604d2
to
7b27027
Compare
zeptometer
commented
Mar 4, 2024
| |> flleq [2.; 3.; 5.; neg 2.; neg 3.; neg 5.; 6.]) | ||
| |> Expect.is-true | ||
| )); | ||
| it `virtually test exp2i` (fun () -> ( |
There was a problem hiding this comment.
What would be a good description? @nyuichi
zeptometer
commented
Mar 4, 2024
|
|
||
| let fn-test-cases = open Test in | ||
| describe `Fn module` [ | ||
| it `make recursive function with fix` (fun x -> ( |
There was a problem hiding this comment.
The original test case calls Debug.log for each recursion, but it is not feasible in satysfi-test. That's why I write this case in this way.
zeptometer
force-pushed
the
zeptometer/GH-142
branch
3 times, most recently
from
52e2268
to
a526552
Compare
nyuichi
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates regression tests from
generic.satyto unit tests with satysfi-test. This closes #142.What this PR does
This PR introduces a new directory
/testwith test definitions. The top-level filemain.test.satyloads all test sources.run-test.shcompiles the whole source in text-mode, and outputreport.txt, including test result. It runs in CI to ensure that satysfi-base works up to expectation, which you can find.github/workflows/ci.yml.Why to migrate to satysfi-test
The regression tests from
generic.satymake snapshots from compiler output, which is not very readable and maintainable. Unit tests with satysfi-test make tests organized, clear and maintainable. It also allows test-first development: It will be beneficial for future development.