Close button in CG rather than using bundled images #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removes all bundle resources * Removes NSBundle category * Changes the podspec to get rid of bundle * Adds a NYTCloseButton which is a UIButton with an overrided drawRect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attaching resource bundles with iOS frameworks is a rather broken process. When you have simple graphics to package with a framework, it is preferable (when practical) to draw them in CoreGraphics rather than bundle them as images. It also reduces the framework footprint.
In this case, after installing from Cocoapods, XCode was giving me a lot of trouble claiming that the bundle did not exist. Instead of bothering to fix this, I just redid the button in CoreGraphics.