Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github.com/golang/protobuf is replaced by google.golang.org/protobuf #151

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

amjadjibon
Copy link

@amjadjibon amjadjibon commented Nov 19, 2023

Module github.com/golang/protobuf is replaced by google.golang.org/protobuf

Refer to issue #140

@amjadjibon amjadjibon changed the title Module update github.com/golang/protobuf is replaced by google.golang.org/protobuf Nov 19, 2023
@amjadjibon amjadjibon changed the title github.com/golang/protobuf is replaced by google.golang.org/protobuf github.com/golang/protobuf is replaced by google.golang.org/protobuf #147 Nov 19, 2023
@amjadjibon amjadjibon changed the title github.com/golang/protobuf is replaced by google.golang.org/protobuf #147 github.com/golang/protobuf is replaced by google.golang.org/protobuf Nov 19, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 184 lines in your changes are missing coverage. Please review.

Comparison is base (9f540f6) 49.98% compared to head (7a7dfe2) 49.82%.

Files Patch % Lines
phonemetadata.pb.go 51.06% 133 Missing and 5 partials ⚠️
phonenumber.pb.go 52.08% 44 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   49.98%   49.82%   -0.16%     
==========================================
  Files           9        9              
  Lines        3309     3444     +135     
==========================================
+ Hits         1654     1716      +62     
- Misses       1512     1579      +67     
- Partials      143      149       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour
Copy link
Member

@amjadjibon thanks!

@rowanseymour rowanseymour merged commit 9a6ba00 into nyaruka:main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants