Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marking as sent in redis should include failed messages #799

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

rowanseymour
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 74.48%. Comparing base (0559144) to head (5494cc1).

Files with missing lines Patch % Lines
backends/rapidpro/backend.go 38.46% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   74.51%   74.48%   -0.04%     
==========================================
  Files         111      111              
  Lines       13448    13440       -8     
==========================================
- Hits        10021    10011      -10     
- Misses       2697     2698       +1     
- Partials      730      731       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rowanseymour rowanseymour merged commit 38ec481 into main Nov 5, 2024
5 of 7 checks passed
@rowanseymour rowanseymour deleted the mark_sent branch November 5, 2024 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant