CI/macOS: Update to macOS 12 #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't seem necessary to run brew update before installing things, and as a bonus we avoid facing random errors while performing such updates.
Qt 5 still needs this, though.
The macOS 11 runner has been removed from GitHub in June: https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
zjeffer
approved these changes
Jul 17, 2024
|
Hey, @guihkx, thanks for this! The oldest Mac I got around me is from 2017 running macOS 12. Seems to work well 👍 |
nuttyartist
approved these changes
Jul 17, 2024
|
I actually messed up something, let me fix it real quick. |
That's the minimum macOS version supported by Qt 6: https://doc.qt.io/qt-6/macos.html#supported-versions
|
Should be good now. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macOS 11 runner was removed by GitHub Actions in June:
https://github.blog/changelog/2024-05-20-actions-upcoming-changes-to-github-hosted-macos-runners/
@nuttyartist Can you please check if the Qt 5 build still runs on macOS 10.15?