Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incompatibility with Qt 6.6 #656

Conversation

dmytrovoytko
Copy link

Please consider this PR to fix #652 so Kanban view works again!

Copy link
Collaborator

@guihkx guihkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for working on this! I tested your changes locally with Qt 6.6.1 and I can confirm they fix #652.

Pinging @nuttyartist though, since he knows this QML stuff better.

@zjeffer
Copy link
Collaborator

zjeffer commented Dec 1, 2023

Great that you fixed this!

I don't understand why it fixes it, though. Do you have any documentation explaining why enabled doesn't work but isEnabled does? Is enabled a built-in property we cannot use?

@guihkx
Copy link
Collaborator

guihkx commented Dec 1, 2023

Is enabled a built-in property we cannot use?

Judging by the error message, that seems to be exactly the case (at least with Qt 6.6):

qrc:/qt/qml/OptionItemButton.qml:15:5: Cannot override FINAL property 
         property bool enabled: true 
         ^

@zjeffer
Copy link
Collaborator

zjeffer commented Dec 1, 2023

Shouldn't we then, instead of renaming it to isEnabled, remove the line where we (re)define the enable property, and use the built-in one instead? Keep in mind I have next to zero experience with QML so I'm talking out of my ass here ;)

@guihkx
Copy link
Collaborator

guihkx commented Dec 1, 2023

Perhaps, but given that this property was (possibly?) only introduced in Qt 6.6, I'm not sure if we'd be over-complicating the implementation for older Qt versions...

Keep in mind I have next to zero experience with QML so I'm talking out of my ass here ;)

Hey, me too! :)

zjeffer added a commit that referenced this pull request Dec 1, 2023
@zjeffer
Copy link
Collaborator

zjeffer commented Dec 1, 2023

Created a new PR to test the builds: #657

If it works on previous versions, we can close this and merge 657 instead.

@zjeffer
Copy link
Collaborator

zjeffer commented Dec 1, 2023

#657 works, closing in favour of that PR.

Thanks @dmytrovoytko!

@zjeffer zjeffer closed this Dec 1, 2023
@nuttyartist
Copy link
Owner

Thanks everybody (: I was programming this just when I started studying QML so some of the Kanban code is still rough around the edges. @zjeffer, your PR works just fine. And thanks @dmytrovoytko for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor settings window is broken with Qt 6.6
4 participants