-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incompatibility with Qt 6.6 #656
Fix incompatibility with Qt 6.6 #656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for working on this! I tested your changes locally with Qt 6.6.1 and I can confirm they fix #652.
Pinging @nuttyartist though, since he knows this QML stuff better.
Great that you fixed this! I don't understand why it fixes it, though. Do you have any documentation explaining why |
Judging by the error message, that seems to be exactly the case (at least with Qt 6.6):
|
Shouldn't we then, instead of renaming it to |
Perhaps, but given that this property was (possibly?) only introduced in Qt 6.6, I'm not sure if we'd be over-complicating the implementation for older Qt versions...
Hey, me too! :) |
Created a new PR to test the builds: #657 If it works on previous versions, we can close this and merge 657 instead. |
#657 works, closing in favour of that PR. Thanks @dmytrovoytko! |
Thanks everybody (: I was programming this just when I started studying QML so some of the Kanban code is still rough around the edges. @zjeffer, your PR works just fine. And thanks @dmytrovoytko for spotting this. |
Please consider this PR to fix #652 so Kanban view works again!