Skip to content

Commit

Permalink
chore(linux): Remove low resolution icons
Browse files Browse the repository at this point in the history
This is just an aesthetical change.

Long story short:

AppImages have a default icon. For some reason, our AppImage-making
tool always chooses the lowest resolution icon we have (16x16) as the
default one, and there's no way to specify a different icon (AFAIK).

End result: Our AppImage icon looks really bad on file managers that
support previewing AppImage files via libappimage, like Dolphin.

Quick and dirty solution: Keep only icons that are 128x128 and above.
  • Loading branch information
guihkx committed Sep 5, 2023
1 parent 7ab9224 commit 10bed34
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 11 deletions.
12 changes: 1 addition & 11 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -429,17 +429,7 @@ elseif(UNIX)
install(FILES ${CMAKE_BINARY_DIR}/${APP_ID}.metainfo.xml
DESTINATION ${CMAKE_INSTALL_DATAROOTDIR}/metainfo)

foreach(
ICON_SIZE
16
22
24
32
48
64
128
256
512)
foreach(ICON_SIZE 128 256 512)
install(
FILES
${PROJECT_SOURCE_DIR}/packaging/linux/common/icons/${ICON_SIZE}x${ICON_SIZE}/notes.png
Expand Down
Binary file removed packaging/linux/common/icons/16x16/notes.png
Binary file not shown.
Binary file removed packaging/linux/common/icons/22x22/notes.png
Binary file not shown.
Binary file removed packaging/linux/common/icons/24x24/notes.png
Binary file not shown.
Binary file removed packaging/linux/common/icons/32x32/notes.png
Binary file not shown.
Binary file removed packaging/linux/common/icons/48x48/notes.png
Binary file not shown.
Binary file removed packaging/linux/common/icons/64x64/notes.png
Binary file not shown.

0 comments on commit 10bed34

Please sign in to comment.