Additional Dependencies #372
Conversation
|
|
||
| - name: Install NMMA (base) | ||
| run: | | ||
| python -m pip install --no-cache-dir 'nmma @ git+https://github.com/sahiljhawar/nmma.git@dependencies' |
There was a problem hiding this comment.
change git link after merge
|
@atoivonen13 you can add more files here |
|
@sahiljhawar you want me to move the changes from #369 here? |
|
@atoivonen13 This PR already contains the changes you made in #369. I mean, if you have more optional dependency files, you can add them in this PR. |
|
@sahiljhawar it does not appear I can push to your fork, but you can add sklearn as its own file and optional dependency. I think the thought was if we were going to make tensorflow optional, we might as well make sklearn option, as users usually use one or the other |
|
okay. But there should be atleast one ML package which installs with NMMA and anyone can right away start with very basic analysis. What do you think @atoivonen13 ? |
|
@sahiljhawar first off, looks like pyFFTW made a release. Second I was just chatting with Michael about making sklearn a separate file and he thought it makes sense to be agnostic to the methods and just be clear in documentation |
linux packages refact no need to remove name change add tf
ubuntu dependecy check for macos macos conditional hdf5 add ubuntu condition pip install try basictex change cache
sahiljhawar
force-pushed
the
dependencies
branch
from
8dd83d2
to
13e0ae2
Compare
|
@atoivonen13 yes I know about PyFFTW, already pushed Python 3.12 updates to the repo. also added new file for sklearn |
|
I guess, need to write a few notes on MacOS installation (and Python 3.12 in particular) |
|
Thanks @sahiljhawar I was mainly just checking in to see when this would be merged and we would do a release. Is there anything else I need to do here? |
|
@atoivonen13, I think this is done. Waiting for @mcoughlin approval for merge. |
mcoughlin
merged commit 77611a0
into
nuclear-multimessenger-astronomy:main
|
@sahiljhawar A release would be nice when you can so I can make sure everything works with em-bright, but it does not need to be done today or anything. I figured between this and the pyfftw a release is merited, are we waiting on anything else to include in 0.2.1? |
|
I remember from one of the NMMA calls that Henrik has something to include in the next release, however I am not super sure about it. |
|
@sahiljhawar Henrik says we can go ahead and will get it into the next one. |
|
@atoivonen13 @mcoughlin Done! |
@atoivonen13 Reqs and test for additional dependencies. Move #369 here
Installation CI only runs when *_requirements.txt or toml file is changed