Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let svdmodel-benchmark take comma-separated filters #315

Merged

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Jan 29, 2024

This PR standardizes filter input across NMMA by modifying svdmodel_benchmark.py to take comma-separated filters (instead of space-separated).

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bfhealy bfhealy merged commit a1b5850 into nuclear-multimessenger-astronomy:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants