Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added LANL morphology function to model_parameters.py #295

Closed
wants to merge 1 commit into from

Conversation

bking-astro
Copy link
Collaborator

There were function missing from model_parameters.py for all 4 LANL model morphologies.

@bfhealy bfhealy self-requested a review December 20, 2023 18:09
Copy link
Collaborator

@bfhealy bfhealy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bking-astro Looks like we ended up committing to a branch in the main NMMA repo rather than your fork of the repo. To fix this, could you please:

  • run git remote -v from your nmma directory
  • Reorganize your remotes for NMMA such that origin points to your fork and upstream points to this repo (using git remote rm <name> and git remote add <name> <https link>
  • Run git pull upstream main and then git push origin main to update your forked repo
  • Reopen this PR from a branch in your forked repo

I'm happy to jump on zoom again to help implement this if you're available.

@bfhealy
Copy link
Collaborator

bfhealy commented Dec 27, 2023

See #297

@bfhealy bfhealy closed this Dec 27, 2023
@sahiljhawar sahiljhawar deleted the add_lanl_funcs branch September 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants