Caching and test for GP #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge, injection test is failing randomly. |
|
Removed GRB model from injections.py test. Also, need to check the availability of caches from main branch to feature branch. |
|
Cache present on the main branch cannot be accessed by the feature branches. This means, whenever PR comes, new caches are added to the repo alongside the cache of the main branch. Commit 5b374d4 adds a post PR merge (and closed) cache deletion workflow. |
|
@mcoughlin This can be merged now. Tests are passing. Cache workflow will be in action after the merge. In another PR I will pin parameters for GRB. |
mcoughlin
merged commit d570118
into
nuclear-multimessenger-astronomy:main
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the use of caching to save the SVD models as cache and use them for all the future runs without the need to download models everytime. Fetching models from Zenodo is really slow, so for now the
svdmodel.taris hosted on Potsdam server. Following this, the analysis test has been updated to perform test onBu2019lmsince it makes use of the model. Also, note that if the tests are being used as is, do not use or create (from a code) any local folder by the namesvdmodelsas this can cause problems.Note for admins: I would advise you to clear all the caches of this repo in order to have a fresh start.