Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native compatibility for Fritz lightcurve data #293

Closed
tylerbarna opened this issue Dec 19, 2023 · 0 comments · Fixed by #304
Closed

Add native compatibility for Fritz lightcurve data #293

tylerbarna opened this issue Dec 19, 2023 · 0 comments · Fixed by #304
Assignees
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Collaborator

Feature Summary
Given the close ties this project has with Fritz, it would be useful for local instances of NMMA to have a more straightforward method of ingesting Fritz lightcurve data.

Usage / behavior
There's 2 ways this could be approached: either at the time lightcurve-analysis is called, NMMA could check if the lightcurve file provided was in the format expected by NMMA, and, if not, convert it to a .dat or .json format that is compatible with NMMA.

Alternatively, we could have a separate function for doing file conversions.

Alternative Solutions
This would still be useful even if the above is implemented, but a page in the documentation detailing the expected format of lightcurves for NMMA analysis would be beneficial to users.

Implementation details
@bfhealy has already implemented this feature as part of the NMMA Fritz API, which can be seen here. This conversion code can be integrated into NMMA in one of the ways outlined above.

@tylerbarna tylerbarna added the enhancement New feature or request label Dec 19, 2023
@tylerbarna tylerbarna added this to the Analysis Tools milestone Dec 19, 2023
@bfhealy bfhealy linked a pull request Jan 5, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants