Add tool to convert skyportal lightcurves to nmma format #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bfhealy in show photometry table, I get mag and magerr. I opened a quick PR for the export button (skyportal/skyportal#4708), although honestly I kind of wonder if we should remove this button and focus on the photometry table, which seems better. What do you think? |
|
@mcoughlin Thanks for that PR - I also think the photometry table is the better place to be downloading lightcurves (I was testing only with the "Export Bold Light Curve to CSV" button). |
bfhealy
changed the title
|
@mcoughlin Any concern about the test failures? They look to be related to coveralls. |
|
@bfhealy not really. can usually rerun those tests. |
sahiljhawar
merged commit 96e474d
into
nuclear-multimessenger-astronomy:main
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a tool to convert light curves downloaded from the skyportal/fritz frontend to NMMA format. Also, the Injections & observational data documentation is updated with an example lightcurve downloaded from SkyPortal.