Do not Review: [nrf noup]: Threading: Adding usage of PSA_CRYPTO_THREAD_SAFE #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-This commit allows for thread-safety to be enabled for legacy and/or HW accelerator mutex support regardless of the thread-safety of the PSA core in itself. It does this by changing the usage of MBEDTLS_THREADING_C define in PSA core scope (which is shared) into PSA_CRYPTO_THREAD_SAFE which is intended to only apply for the core itself (3 mutexes: for global data, rng and slot management. -This commit is dependent on propagating of PSA_CRYPTO_THREAD_SAFE in the generated configuration file (nrf-psa-crypto-config.h) Note: This commit is being tested out to see if we can achieve a ABI compliance for pre-compiled OpenThread libraries that are currently built to be shared between different build-types. Signed-off-by: Frank Audun Kvamtrø <frank.kvamtro@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-This commit allows for thread-safety to be enabled for legacy and/or
HW accelerator mutex support regardless of the thread-safety of
the PSA core in itself. It does this by changing the usage of
MBEDTLS_THREADING_C define in PSA core scope (which is shared) into
PSA_CRYPTO_THREAD_SAFE which is intended to only apply for the
core itself (3 mutexes: for global data, rng and slot management.
-This commit is dependent on propagating of PSA_CRYPTO_THREAD_SAFE
in the generated configuration file (nrf-psa-crypto-config.h)
Note: This commit is being tested out to see if we can achieve a ABI compliance for pre-compiled OpenThread libraries that are currently built to be shared between different build-types.
This is not ready for review. It is used to run tests for the aforementioned ABI compliance issues