nrf_rpc: detect reboot of the remote #1581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise an error when the remote sends an init packet with unknown destination group ID after the group has been bound, which indicates a reboot of the peer. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
|
Converting to draft, as after second thought I'm not sure if reporting a reboot as an error won't cause some issues on existing deployments. Maybe we should add another callback to |
alxelax
reviewed
Nov 22, 2024
| @@ -379,6 +380,11 @@ static void internal_tx_handler(void) | |||
| case NRF_RPC_TASK_GROUP_INIT: { | |||
| const struct nrf_rpc_group *group = task.group_init.group; | |||
|
|
|||
| if (task.group_init.signal_reboot) { | |||
There was a problem hiding this comment.
Hmm... Why should device send error instead of notifying application about rebooted remote and reply to remote?
There was a problem hiding this comment.
nrf_rpc_err does notify the application about the error, and only sends the error in certain cases. But I would say, you probably will like #1583 approach more than this one :)
There was a problem hiding this comment.
I think the another one is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error when the remote sends an init packet with unknown destination group ID after the group has been bound, which indicates a reboot of the peer.