Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nRF5340 audio fixes #19135

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

greg-fer
Copy link
Contributor

  • doc: nrf5340_audio: remove child image mention

    Removed the mention of the child image directory from the docs.
    The application uses sysbuild as other applications.
    This mention was a doc bug.
    OCT-3244 and NCSDK-30393.

  • doc: nrf5340_audio: clarify building steps

    Provided extra information for the building steps, including
    cross-links. Updated configuration file list. Added a section on the
    FOTA page about building. TECHDOC-3100.

Removed the mention of the child image directory from the docs.
The application uses sysbuild as other applications.
This mention was a doc bug.
OCT-3244 and NCSDK-30393.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
@greg-fer greg-fer added CI-disable Disable CI for this PR doc only labels Nov 28, 2024
@greg-fer greg-fer added this to the 2.9.0 milestone Nov 28, 2024
@greg-fer greg-fer requested a review from a team as a code owner November 28, 2024 13:11
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 28, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 28, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI


* ``nrf5340_audio_dk_snr`` -- This field lists the SEGGER serial number.
You can check this number on the sticker on the nRF5340 Audio development kit.
Alternatively, connect the development kit to your PC and run ``nrfjprog -i`` in a command window to print the SEGGER serial number of the kit.
You can check this five-digit number on the sticker on the nRF5340 Audio development kit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be 10 digits.

*******************************

Use the :ref:`nrf53_audio_app_building_standard` procedure to build the nRF5340 Audio applications with the FOTA configuration.
Make sure to provide the :ref:`correct configuration file <nrf53_audio_app_building_config_files>` :file:`prj_fota.conf` when running the build command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an example in here:
west build -b nrf5340_audio_dk/nrf5340/cpuapp --pristine -- -DCONFIG_AUDIO_DEV=1 -DFILE_SUFFIX=fota

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in building.rst.

Select the correct board when prompted with the popup or add the ``--snr`` parameter followed by the SEGGER serial number of the correct board at the end of the ``nrfjprog`` command.
Select the correct board when prompted with the popup.
Alternatively, you can add the ``--snr`` parameter followed by the SEGGER serial number of the correct board at the end of the ``nrfjprog`` command.
You can check the serial numbers of the connected devices with the ``nrfutil device list`` command.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nrfjprog seems will be deprecated, but great that we still can use that at the moment.
Maybe we can replace 'nrfutil device list' with 'nrfjprog -i', so customer won't confuse from different tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've replaced nrfjprog for this reason in this PR, but I will mention both.


This command builds the headset and the gateway applications with ``debug`` version of both the application core binary and the network core binary - and programs each to its respective core.
python buildprog.py -c both -b debug -d both -p
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a tiny example for showing "--pristine" which for "pristine build"

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

* Core type (``-c`` parameter): ``app``, ``net``, or ``both``
* Application version (``-b`` parameter): either ``release`` or ``debug``
* Device type (``-d`` parameter): ``headset``, ``gateway``, or ``both``
The script can handle building and programming at the same time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The script can handle building and programming at the same time.
The script handles building and parallel programming of multiple kits.


* Programming (``-p`` parameter) -- If you run the building script with this parameter, you can program one or both of the cores after building the files.
* Sequential programming (``-s`` parameter) -- If you encounter problems while programming, include this parameter alongside other parameters to program sequentially.
* Programming (``-p`` parameter) -- If you run the building script with this parameter, you can program one or both of the cores after building the files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Programming (``-p`` parameter) -- If you run the building script with this parameter, you can program one or both of the cores after building the files.
* Programming (``-p`` parameter) -- If you run the buildprog script with this parameter, you can program one or both of the cores after building the files.

Use the :ref:`nrf53_audio_app_building_standard` procedure to build the nRF5340 Audio applications with the FOTA configuration.
Make sure to provide the :ref:`correct configuration file <nrf53_audio_app_building_config_files>` :file:`prj_fota.conf` when running the build command.

The :ref:`script-based method <nrf53_audio_app_building_script_running>` does not support building and programming the FOTA upgrades.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we link to some pm_static.yaml description? Getting this set up right is important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this caution earlier in the configuration section

.. caution::
The application is provided with a memory partition configuration in :file:pm_static_fota.yml, which is required to perform FOTA using an external flash.
The partition configuration is an example that can be changed between versions, and can be incompatible with existing devices.
For this reason, always create a partition configuration that suits your application.
See :ref:partition_manager for more information on how to create a partition configuration.

In addition, the application features the :file:`child_image` directory with :file:`hci_ipc.conf`.
This file contains the necessary configurations for nRF5340 Audio applications to run the :zephyr:code-sample:`bluetooth_hci_ipc` sample with :ref:`SoftDevice Controller for LE Isochronous Channels <nrfxlib:softdevice_controller_iso>` support.
* :file:`prj_fota.conf` is the optional configuration file used for FOTA DFU.
When used, the build system builds the debug version of the application (:file:`prj.conf`), but with the features needed to perform DFU over Bluetooth LE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I got a bit uncertain. Will this build the debug version?

Copy link
Contributor Author

@greg-fer greg-fer Nov 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this description from Andreas from building.rst, yes:

- | Builds the debug version of the application with the features needed to perform DFU over Bluetooth LE, and includes bootloaders so that the applications on both the application core and network core can be updated.


* ``nrf5340_audio_dk_snr`` -- This field lists the SEGGER serial number.
You can check this number on the sticker on the nRF5340 Audio development kit.
Alternatively, connect the development kit to your PC and run ``nrfjprog -i`` in a command window to print the SEGGER serial number of the kit.
You can check this five-digit number on the sticker on the nRF5340 Audio development kit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The json-file needs the entire 10-digit number to flash. There is a 12-digit number when running nrfutil device list, so if the first 2 zeros are removed we have the correct 10-digit number


* ``nrf5340_audio_dk_snr`` -- This field lists the SEGGER serial number.
You can check this number on the sticker on the nRF5340 Audio development kit.
Alternatively, connect the development kit to your PC and run ``nrfjprog -i`` in a command window to print the SEGGER serial number of the kit.
You can check this five- or ten-digit number on the sticker on the nRF5340 Audio development kit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be ten-digit. I tested with five, doesn't work

Provided extra information for the building steps, including
cross-links. Updated configuration file list. Added a section on the
FOTA page about building. TECHDOC-3100.

Signed-off-by: Grzegorz Ferenc <Grzegorz.Ferenc@nordicsemi.no>
@greg-fer greg-fer requested a review from a team as a code owner November 28, 2024 14:02
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-disable Disable CI for this PR doc only doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants