Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUIT: add "enter recovery button" handling #18738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ahasztag
Copy link
Contributor

@ahasztag ahasztag commented Nov 7, 2024

No description provided.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Nov 7, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 1851e12d0f9622cfb69cec4143ea31a4ab61f92b

more details

sdk-nrf:

PR head: 1851e12d0f9622cfb69cec4143ea31a4ab61f92b
merge base: c6a3f97bd264b17c8fb7089ecf7de6a5972677c0
target head (main): 19945a632cd9d772f5d094f22a97b5180b7be33b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8)
samples
│  ├── suit
│  │  ├── recovery
│  │  │  ├── prj.conf
│  │  │  ├── sysbuild
│  │  │  │  │ hci_ipc.conf
│  │  ├── smp_transfer
│  │  │  ├── sysbuild
│  │  │  │  │ recovery.overlay
subsys
│  ├── suit
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── recovery_button
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  │ suit_recovery_button.c

Outputs:

Toolchain

Version: b81a7cd864
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b81a7cd864_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 119
  • ✅ Integration tests
    • ✅ test-sdk-dfu
    • ⚠️ test-sdk-dfu
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

This commit enables LTO on both cores in the default
SUIT recovery application.

This allows to save ~10kB on the application core
and ~5kB on the radio core.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag ahasztag force-pushed the NCSDK-29999_recovery_button_variant_subsys branch 2 times, most recently from ac15a68 to 5aee57e Compare November 14, 2024 11:11
@ahasztag ahasztag force-pushed the NCSDK-29999_recovery_button_variant_subsys branch 2 times, most recently from 5fb2be8 to c1f64b7 Compare November 18, 2024 16:40
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

This commit adds code allowing to enter SUIT foreground update
(in most cases the same as recovery) mode via keeping
a button pressed during system bootup.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag ahasztag force-pushed the NCSDK-29999_recovery_button_variant_subsys branch from c1f64b7 to 1851e12 Compare November 19, 2024 15:19
@ahasztag ahasztag marked this pull request as ready for review November 19, 2024 15:19
@ahasztag ahasztag requested review from a team as code owners November 19, 2024 15:19
@ahasztag ahasztag added the DNM label Nov 19, 2024
@ahasztag
Copy link
Contributor Author

DNM until #18525 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants