Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: sdk-nrfxlib: Pull command status check #14326

Closed
wants to merge 1 commit into from
Closed

manifest: sdk-nrfxlib: Pull command status check #14326

wants to merge 1 commit into from

Conversation

ajayparida
Copy link
Contributor

Pull command status check phase1 changes.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 4, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 4, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@a1ee70b (main) nrfconnect/sdk-nrfxlib#1239 nrfconnect/sdk-nrfxlib#1239/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 4, 2024 •
edited
Loading

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
desktop52_verification X
doc-internal X
test-fw-nrfconnect-apps X
test-fw-nrfconnect-ble_mesh X
test-fw-nrfconnect-ble_samples X
test-fw-nrfconnect-boot X
test-fw-nrfconnect-chip X
test-fw-nrfconnect-fem X
test-fw-nrfconnect-nfc X
test-fw-nrfconnect-nrf-iot_cloud X
test-fw-nrfconnect-nrf-iot_libmodem-nrf X
test-fw-nrfconnect-nrf-iot_lwm2m X
test-fw-nrfconnect-nrf-iot_mosh X
test-fw-nrfconnect-nrf-iot_nrf_provisioning X X
test-fw-nrfconnect-nrf-iot_positioning X
test-fw-nrfconnect-nrf-iot_samples X
test-fw-nrfconnect-nrf-iot_serial_lte_modem X
test-fw-nrfconnect-nrf-iot_thingy91 X
test-fw-nrfconnect-nrf-iot_zephyr_lwm2m X
test-fw-nrfconnect-nrf_crypto X
test-fw-nrfconnect-proprietary_esb X
test-fw-nrfconnect-ps X
test-fw-nrfconnect-rpc X
test-fw-nrfconnect-rs X
test-fw-nrfconnect-tfm X
test-fw-nrfconnect-thread X
test-fw-nrfconnect-zigbee X
test-low-level X
test-sdk-audio X
test-sdk-dfu X
test-sdk-find-my X
test-sdk-mcuboot X
test-sdk-pmic-samples X
test-sdk-sidewalk X
test-sdk-wifi X
test_ble_commit X

All integration tests: null

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@ajayparida ajayparida force-pushed the cmd_status_check_phase1 branch 6 times, most recently from 2bd1b9b to d12d4d1 Compare March 13, 2024 07:31
@ajayparida ajayparida force-pushed the cmd_status_check_phase1 branch 8 times, most recently from 98a1a9a to 32a6e21 Compare May 17, 2024 07:19
@rakeswar2001 rakeswar2001 marked this pull request as draft May 21, 2024 05:59
@ajayparida ajayparida force-pushed the cmd_status_check_phase1 branch 2 times, most recently from 53061e5 to 04d2728 Compare July 31, 2024 06:12
@ajayparida ajayparida marked this pull request as ready for review July 31, 2024 06:14
@rakeswar2001 rakeswar2001 force-pushed the cmd_status_check_phase1 branch 2 times, most recently from 2f43369 to a7546c8 Compare August 12, 2024 05:09
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Aug 12, 2024 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 54

Inputs:

Sources:

sdk-nrf: PR head: 27a6a3dee6dc4c850edcd06b6edecb4d14735d1c
nrfxlib: PR head: 7e233ee3e38b9e813fcd338ed2d0b00eecadeb9d

more details

sdk-nrf:

PR head: 27a6a3dee6dc4c850edcd06b6edecb4d14735d1c
merge base: 1a56b7a984c267e9b598e2882fb663b96282ac2b
target head (main): a46eda7f14f9c0f7ad79d24c362199e44197b3dd
Diff

nrfxlib:

PR head: 7e233ee3e38b9e813fcd338ed2d0b00eecadeb9d
merge base: a1ee70bcd10ddc28fdff792459e019b04f1c8879
target head (main): 837f9c00fc9470b91a586b9df4d84f2847f1c3a3
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10) 
nrfxlib
│  ├── nrf_wifi
│  │  ├── fw_bins
│  │  │  ├── default
│  │  │  │  │ nrf70.bin
│  │  │  ├── radio_test
│  │  │  │  │ nrf70.bin
│  │  │  ├── scan_only
│  │  │  │  │ nrf70.bin
│  │  │  ├── system_with_raw
│  │  │  │  │ nrf70.bin
│  │  ├── fw_if
│  │  │  ├── umac_if
│  │  │  │  ├── inc
│  │  │  │  │  ├── default
│  │  │  │  │  │  │ fmac_structs.h
│  │  │  │  │  ├── fw
│  │  │  │  │  │  ├── host_rpu_umac_if.h
│  │  │  │  │  │  │ lmac_if_common.h
│  │  │  │  ├── src
│  │  │  │  │  ├── default
│  │  │  │  │  │  │ fmac_api.c
│  │  │  │  │  │ event.c
west.yml

Outputs:

Toolchain

Version: 9583beca34
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:9583beca34_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 53
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk

Note: This message is automatically posted and updated by the CI

@rakeswar2001 rakeswar2001 force-pushed the cmd_status_check_phase1 branch 6 times, most recently from f781adf to be3f846 Compare August 19, 2024 07:00
@rakeswar2001 rakeswar2001 force-pushed the cmd_status_check_phase1 branch 2 times, most recently from a3f98ea to d9b6495 Compare August 21, 2024 09:40
@rakeswar2001 rakeswar2001 requested a review from a team as a code owner September 24, 2024 06:02
@markaj-nordic
Copy link
Contributor

markaj-nordic commented Sep 27, 2024 •
edited
Loading

@ajayparida the Matter failure is caused by the net_mgmt API returning error when requesting for low power mode:
https://github.com/nrfconnect/sdk-connectedhomeip/blob/89eb37b47ca8e4b9d309c431bde30bdb19d07577/src/platform/nrfconnect/wifi/WiFiManager.cpp#L696

I believe the nrfxlib related change refines commands handling between host and RPU, so it looks like a regression to me. Is there any test in WiFi suite that checks the net_mgmt(NET_REQUEST_WIFI_PS...) call?

Does application code require alignments after your change?

@ajayparida
Copy link
Contributor Author

@ajayparida the Matter failure is caused by the net_mgmt API returning error when requesting for low power mode: https://github.com/nrfconnect/sdk-connectedhomeip/blob/89eb37b47ca8e4b9d309c431bde30bdb19d07577/src/platform/nrfconnect/wifi/WiFiManager.cpp#L696

I believe the nrfxlib related change refines commands handling between host and RPU, so it looks like a regression to me. Is there any test in WiFi suite that checks the net_mgmt(NET_REQUEST_WIFI_PS...) call?

Does application code require alignments after your change?

Hi,

Yes, there is change in nrfxlib. Host passes the commands to rpu and will wait for command status event. In a way host will know, command has been indeed received by rpu and processed. On timeout, in case no event received it will return failure. This way it helps to know that command has been received by fw and processed.

There is no separate test suite, we can use existing "shell" sample to set ps on/off("cmd_wifi_ps on/off"). It will invoke net_mgmt(NET_REQUEST_WIFI_PS...) with params.enabled=on/off as being done in your code.

No, I don't think application code require alignment. As in case host driver doesn't receive status event, it will return failure . It will be same as currenetly expected at your application for failure of command. It will call "ChipLogError(DeviceLayer, "Set low power mode request failed");"

I have also asked UMAC firmware team to check they are giving event status for the commad NRF_WIFI_UMAC_CMD_SET_POWER_SAVE".

@ajayparida @rakeswar2001
manifest: sdk-nrfxlib: Pull command status check
27a6a3d 
Pull command status check related changes for commands not
expecting data from firmware only status event(phase 1 changes).

Signed-off-by: Ajay Parida <ajay.parida@nordicsemi.no>
doublemis1
doublemis1 requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@doublemis1 doublemis1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to upmerge issues, the nRF7002 testing on Matter over WiFI is disabled on integration, however we found regression on that PR (current state).
After disabling the nRF7002DK in Matter testing the Integration tests will be green, however it does not mean that the regression has been fixed. Please contact me if the issue will be fixed, I can verify it on desk and give result.

@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 22, 2024
@thst-nordic thst-nordic closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doublemis1 doublemis1 doublemis1 requested changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@tejlmand tejlmand Awaiting requested review from tejlmand

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-nrfxlib Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ajayparida @NordicBuilder @markaj-nordic @doublemis1 @thst-nordic