Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for brushless servo upgrade #197

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

alexrudd2
Copy link
Contributor

Closes #136

Supercedes #162

@alexrudd2 alexrudd2 marked this pull request as draft October 26, 2023 18:01
jedahan and others added 9 commits October 26, 2023 13:39
This speeds up start times, allows for live reloads, and makes saxi buildable on a raspberry pi zero (webpack OOMs even with 1.5Gb of memory).
---------

Co-authored-by: Jonathan Dahan <git@jonathan.is>
Co-authored-by: Alex Ruddick <a.ruddick@numat-tech.com>

Co-authored-by: Jonathan Dahan <git@jonathan.is>
* update dependency serialport to v12

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Ruddick <a.ruddick@numat-tech.com>
* Add pen cli command to move the pen to a percent position

---------

Co-authored-by: Jonathan Dahan <git@jonathan.is>
Co-authored-by: Alex Ruddick <a.ruddick@numat-tech.com>
Co-authored-by: Alex Ruddick <alexrudd0@gmail.com>
@alexrudd2
Copy link
Contributor Author

I have rebased and dropped most of the dependency updates so those can be done separately. However, the brushless work was built on some of the refactor so it can't quite be done a la carte.

@nornagon
Copy link
Owner

@alexrudd2 this looks like it contains the ESBuild work too, that seems like something that should be fairly straightforward to split out into a separate PR, yeah?

@alexrudd2
Copy link
Contributor Author

@alexrudd2 this looks like it contains the ESBuild work too, that seems like something that should be fairly straightforward to split out into a separate PR, yeah?

Yes, I just need to do it :P. It's a fair bit of work to keep refactoring branches from the fork.

My intention for right now is to show you the code changes for "just" the brushless.

It's of course built upon other changes, but the overall diff should slowly go down as we upstream them (tracked here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brushless
3 participants