feat: Move libpointmatcher build-system logic to norlab-build-system submodule (clean-up and polish) #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not passing argument properly to sub-shell - source instead of run in sub-shell - add bats test - add script to run bats test in N2ST
…n configuration setup, restructure directories
…files and dockerfiles
…instead of re-implementing them. Add bats test
9 tasks
RedLeader962
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reference task NMO-398 in YouTrack board
Refactor out generic logic that can be reuse accros NorLab repositories from libpointmatcher-build-system to norlab-build-system library.
Changes and type of changes:
lpm_crawl_dependencies_build_matrix.bashnot passing argument properly to sub-shellbatstesttests_docker_interactive/, update run configuration setup, restructure directoriesSITREPrelated logic in dotenv files, docker compose files and dockerfilesNBSdocker install andbuildx createrelated logic instead of re-implementing them. Add bats testNBSsubmodule version