-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(proxy): add ability to enable http/https proxy #85
base: master
Are you sure you want to change the base?
Conversation
Add config params in readme
Thanks for the PR! I'll try to check this on Monday (when actually behind a corporate proxy). |
Hi, Is this feature still planed? It seems I have a proxy issue and it could be very useful for me. My Kong container have proxy env vars If I use curl in my container, I can access to my URL (after http_proxy env vars have been added). But oidc-plugin still gives me dns issues. And it seems he's not using proxy parameters. So I'm not sure if it's a classic behavior of the plugin or not to not use proxy env vars ? Debug:
Thank you ! |
@@ -18,6 +18,8 @@ return { | |||
recovery_page_path = { type = "string" }, | |||
logout_path = { type = "string", required = false, default = '/logout' }, | |||
redirect_after_logout_uri = { type = "string", required = false, default = '/' }, | |||
http_proxy = { type = "string", required = false, default = '' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the default value for http_proxy and https_proxy. It's causing to always set the proxy and breaks in non proxy environment
Add http and https proxy. Useful if you're in a corporate network